HomePhabricator

Avoid copying CWalletTx in LoadToWallet

Description

Avoid copying CWalletTx in LoadToWallet

Summary:
The change in walletdb.cpp is easier to review ignoring whitespace.

This change is need to get rid of CWalletTx copy constructor.

This is a backport of Core PR9381 [3/5]
https://github.com/bitcoin/bitcoin/pull/9381/commits/65b9d8f8ddb5a838454efc8bdd6576f0deb65f6d
Depends on D9075

Test Plan: ninja all check-all

Reviewers: #bitcoin_abc, majcosta

Reviewed By: #bitcoin_abc, majcosta

Differential Revision: https://reviews.bitcoinabc.org/D9076

Details

Provenance
Russell Yanofsky <russ@yanofsky.org>Authored on Jan 27 2021, 16:05
PiRKCommitted on Jan 27 2021, 16:06
abc-botPushed on Jan 27 2021, 16:12
Reviewer
Restricted Project
Differential Revision
D9076: Avoid copying CWalletTx in LoadToWallet
Parents
rABCb740449f358f: wallet: Make sure no DescriptorScriptPubKeyMan or WalletDescriptor members areā€¦
Branches
Unknown
Tags
Unknown