HomePhabricator

test: Add format-dependent comparison to bctest

Description

test: Add format-dependent comparison to bctest

This splits the output comparison for bitcoin-tx into two steps:

  • First, check for data mismatch, parsing the data as json or hex depending on the extension of the output file
  • Then, check if the literal string matches

For either of these cases give a different error.

This prevents wild goose chases when e.g. a trailing space doesn't match
exactly, and makes sure that both test output and examples are valid
data of the purported format.

Details

Provenance
Wladimir J. van der Laan <laanwj@gmail.com>Authored on Oct 27 2016, 12:05
deadalnixPushed on May 14 2017, 22:04
Parents
rABC86f9e3dbba41: Merge #9020: rpc: Remove invalid explanation from wallet fee message
Branches
Unknown
Tags
Unknown

Event Timeline

Wladimir J. van der Laan <laanwj@gmail.com> committed rABC6c5cd9d02234: test: Add format-dependent comparison to bctest (authored by Wladimir J. van der Laan <laanwj@gmail.com>).Oct 28 2016, 12:20