HomePhabricator

[backport#11690] [trivial] Fix the StartupWMClass for bitoin-qt, so gnome-shell…

Description

[backport#11690] [trivial] Fix the StartupWMClass for bitoin-qt, so gnome-shell can recognize it

Summary:
b077fe908 fix the StartupWMClass for bitoin-qt, so gnome-shell can recognize it (Evan Klitzke)

Pull request description:

I spent some time trying to figure out how to get the provided `.desktop` file to work correctly in GNOME. When a non-absolute path is used in the desktop file, you need to specify `StartupWMClass` in order for gnome-shell to know that a running application matches one in its desktop database. I also set a version and removed the deprecated `Encoding` field. With these changes, the desktop file passes `desktop-file-validate` cleanly.

P.S. I found this while working on a new spec file for Bitcoin, which you can find here: https://github.com/eklitzke/bitcoin-copr/blob/master/bitcoin.spec . I plan to contribute this work back upstream as well, once I've figured out more of these packaging issues (desktop files being one of them!).

Backport of Core PR11690

Test Plan: I don't use Gnome to test this unfortunately

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D8170

Details

Provenance
MarcoFalke <falke.marco@gmail.com>Authored on Nov 15 2017, 21:39
majcostaCommitted on Oct 29 2020, 15:39
majcostaPushed on Oct 29 2020, 15:40
Reviewer
Restricted Project
Differential Revision
D8170: [backport#11690] [trivial] Fix the StartupWMClass for bitoin-qt, so gnome-shell can recognize it
Parents
rABC6b08ed7779e1: [backport#11140] Trivial: Improve #endif comments
Branches
Unknown
Tags
Unknown