HomePhabricator

test: replace remaining binascii method calls in functional tests

Description

test: replace remaining binascii method calls in functional tests

Summary:
Instances of binascii's methods hexlify, unhexlify, and a2b_hex have been replaced with the build-in bytes module's hex and fromhex methods where appropriate to make bytes <-> hex-string conversions consistent across the functional test files and test_framework.

Also update some code in a comment in serialize_tests.cpp that was using binascii. This code also needed additional changes to work with python3 (because in python 3 you cannot join bytes using a str separator).

This is a backport of core#22619

Test Plan: ninja check-functional-extended

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D11137

Details

Provenance
PiRKAuthored on Mar 7 2022, 09:29
PiRKPushed on Mar 7 2022, 12:39
Reviewer
Restricted Project
Differential Revision
D11137: test: replace remaining binascii method calls in functional tests
Parents
rABCf19bc27b6096: test: refactor: remove hex_str_to_bytes helper
Branches
Unknown
Tags
Unknown