HomePhabricator

add a linter for python imports

Description

add a linter for python imports

Summary:
isort sorts imports by type (CONSTANT_VARIABLE, the CamelCaseClass, then functions_and_variables) and alphabetically, and automatically separated into sections (standard library, external library, internal import).

See D10200's description for the rationale regarding the choice of parameters
--profile=black --line-length=79.

Depends on D10200, D10201, D10202, D10203, D10204, D10205, D10206

Test Plan:

sudo arc liberate
arc lint --everything

Impact on duration
before:

$ time arc lint --everything
...
real	1m5,412s
user	4m6,869s
sys	0m35,975s

after:

$ time arc lint --everything
...
real	1m8,443s
user	4m17,270s
sys	0m38,601s

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D10124

Details

Provenance
PiRKAuthored on Sep 15 2021, 15:37
PiRKPushed on Sep 29 2021, 15:45
Reviewer
Restricted Project
Differential Revision
D10124: add a linter for python imports
Parents
rABCf5ff0c42de56: sort python imports in remaining test_framework and misc files
Branches
Unknown
Tags
Unknown