HomePhabricator

[ecash-herald] Patch bug in daily summary calc

Description

[ecash-herald] Patch bug in daily summary calc

Summary:
Typo resulting in getting last 48 hrs worth of blocks instead of 24, patch

The checker was working, but bc I was mixing up "yesterday" with "today" -- was passing "yesterday" into getAllBlockTxs, which then had to go back in time well more than 144 blocks to get the "right" (wrong) block.

Test Plan: npm test, confirm typo corrected and the "right" date is going into getAllBlockTxs

Reviewers: #bitcoin_abc, emack

Reviewed By: #bitcoin_abc, emack

Differential Revision: https://reviews.bitcoinabc.org/D16945

Details

Provenance
bytesofmanAuthored on Sun, Oct 20, 02:53
bytesofmanPushed on Sun, Oct 20, 10:10
Reviewer
Restricted Project
Differential Revision
D16945: [ecash-herald] Patch bug in daily summary calc
Parents
rABC39186ed634c6: [ecash-lib] Fixed Typo and added ALL_BIP143 to imports on README
Branches
Unknown
Tags
Unknown