HomePhabricator

Increase our max number of outbound peers

Description

Increase our max number of outbound peers

Summary:
The number of inbound peers we support has been bumped a lot in D8605, but the outbound peers (the ones the node connects to, not the ones that connect to the node) remained unchanged. This diff doubles the number of outbounds, so that a node will reach out to 16 full relay (block + tx) peers.

This is the first part of a broader strategy related to actively retrieving avalanche peers. Later diffs will bump this number even more by using reserved slots for avalanche enabled outbound peers.

The MAX_NODE constant from the test framework has been bumped a lot (made possible by D10852) so it won't get in the way of the future diffs and don't need to be updated again.

Ref T1696.

Test Plan:

ninja check-extended

Run a node with no inbound (blocked by firewall) for a while, check the node fills its outbound peer slots and the resources are not exploding. This test has been done on a beefy machine but the resource usage was unnoticeable so it should be OK with more limited machines as well.

Reviewers: #bitcoin_abc, PiRK

Reviewed By: #bitcoin_abc, PiRK

Maniphest Tasks: T1696

Differential Revision: https://reviews.bitcoinabc.org/D10974

Details

Provenance
FabienAuthored on Feb 3 2022, 13:54
FabienPushed on Feb 4 2022, 10:25
Reviewer
Restricted Project
Differential Revision
D10974: Increase our max number of outbound peers
Parents
rABCb4ac4601d570: Bump the timeout for the debug log messages in test_seed_peers
Branches
Unknown
Tags
Unknown
Tasks
Restricted Maniphest Task