HomePhabricator

refactor: add parkdeepreorg and automaticunparking options in ChainstateManager

Description

refactor: add parkdeepreorg and automaticunparking options in ChainstateManager

Summary:
Remove access to the global gArgs for these arguments and replace them by adding fields to the existing ChainstateManager Options truct.

This should eventually allow users of the ChainstateManager to not rely on the global gArgs and instead pass in their own options.

Note that there is no change in behavior for automatic unparking, as the avalanche pointer arg passed to ActiveBestChain is non-null only if args.GetBoolArg("-avalanche", AVALANCHE_DEFAULT_ENABLED) (see init.cpp where node.avalanche is initialized).

Test Plan: ninja all check-all

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D18684

Details

Provenance
PiRKAuthored on Sep 24 2025, 15:22
PiRKPushed on Sep 25 2025, 06:50
Reviewer
Restricted Project
Differential Revision
D18684: refactor: add parkdeepreorg and automaticunparking options in ChainstateManager
Parents
rABC5d5d9cc53591: [ecash-lib] Patch dockerfile for CI
Branches
Unknown
Tags
Unknown