HomePhabricator

Move GenerateSelectSet logic to private method.

Description

Move GenerateSelectSet logic to private method.

Summary:
This separates the socket event collection logic from the logic
deciding which events we're interested in at all.

Partial backport of Core PR14336
https://github.com/bitcoin/bitcoin/pull/14336/commits/7e403c0ae705455aa66f7df9a9a99f462fd4e9a8

Depends on D6459

Test Plan:

ninja
ninja check-all
src/bitcoind -debug=net

Verify normal node connection behavior

Reviewers: O1 Bitcoin ABC, #bitcoin_abc, Fabien, jasonbcox

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, Fabien, jasonbcox

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D6460

Details

Provenance
Patrick Strateman <patrick.strateman@gmail.com>Authored on Sep 25 2018, 19:32
nakihitoCommitted on Jun 9 2020, 23:21
nakihitoPushed on Jun 9 2020, 23:21
Reviewer
Restricted Owners Package
Differential Revision
D6460: Move GenerateSelectSet logic to private method.
Parents
rABC7ef2a7b7612c: Introduce and use constant SELECT_TIMEOUT_MILLISECONDS.
Branches
Unknown
Tags
Unknown