HomePhabricator

Merge #12892: [wallet] [rpc] introduce 'label' API for wallet

Description

Merge #12892: [wallet] [rpc] introduce 'label' API for wallet

Summary:
41ba061 [docs] Add release notes for wallet 'label' API. (John Newbery)
189e0ef [wallet] [rpc] introduce 'label' API for wallet (Wladimir J. van der Laan)

Pull request description:

Add label API to wallet RPC.

This is one step towards #3816 ("Remove bolt-on account system") although it doesn't
actually remove anything yet.

These initially mirror the account functions, with the following differences:

- These functions aren't DEPRECATED in the help
- Help mentions 'label' instead of accounts. In the language used, labels are
  associated with addresses, instead of addresses associated with labels. (unlike
  with accounts.)
- Labels have no balance
  - No balances in `listlabels`
  - `listlabels` has no minconf or watchonly argument
- Like in the GUI, labels can be set on any address, not just receiving addreses
- Unlike accounts, labels can be deleted.
  Being unable to delete them is a common annoyance (see #1231).
  Currently only by reassigning all addresses using `setlabel`, but an explicit
  call `deletelabel` which assigns all address to the default label may make
  sense.

Tree-SHA512: 45cc313c68ad529ce3a15c02181d2ab0083a7e14fe824e2cde34972713fecce512e3d4b9aa46db5355f2baa857c44b234d4fe9709225bc23c7ebbc0e03febbf5

Backport of Core PR12892
https://github.com/bitcoin/bitcoin/pull/12892/

Depends on D3308

Test Plan:

make check
test_runner.py

Reviewers: deadalnix, Fabien, jasonbcox, O1 Bitcoin ABC, #bitcoin_abc, markblundeberg

Reviewed By: Fabien, jasonbcox, O1 Bitcoin ABC, #bitcoin_abc

Differential Revision: https://reviews.bitcoinabc.org/D3949

Details

Provenance
Wladimir J. van der Laan <laanwj@gmail.com>Authored on Apr 11 2018, 09:27
nakihitoCommitted on Nov 5 2019, 21:13
nakihitoPushed on Nov 5 2019, 21:13
Reviewer
Restricted Owners Package
Differential Revision
D3949: Merge #12892: [wallet] [rpc] introduce 'label' API for wallet
Parents
rABC61480f09eadd: Merge #9894: remove 'label' filter for rpc command help
Branches
Unknown
Tags
Unknown