HomePhabricator

When processing RPC commands during warmup phase, parse the request object…
72b9452b1d5fUnpublished

Unpublished Commit · Learn More

Repository Importing: This repository is still importing.

Description

When processing RPC commands during warmup phase, parse the request object before returning an error so that id value can be used in the response.

Prior to this commit, RPC commands sent during Bitcoin's
warmup/startup phase were responded to with a JSON-RPC error
with an id of null, which violated the JSON-RPC 2.0 spec:

id: This member is REQUIRED. It MUST be the same as the value
of the id member in the Request Object. If there was an error
in detecting the id in the Request object (e.g. Parse
error/Invalid Request), it MUST be Null.

Details

Provenance
Forrest Voight <forrest@forre.st>Authored on Jul 2 2015, 01:34
deadalnixPushed on May 14 2017, 22:04
Parents
rABC6bcb0a21c543: Merge pull request #6353
Branches
Unknown
Tags
Unknown

Event Timeline

Forrest Voight <forrest@forre.st> committed rABC72b9452b1d5f: When processing RPC commands during warmup phase, parse the request object… (authored by Forrest Voight <forrest@forre.st>).Jul 2 2015, 01:55