HomePhabricator

Merge #11200: Allow for aborting rescans in the GUI

Authored by Jonas Schnelli <dev@jonasschnelli.ch> on Apr 13 2018, 18:51.

Description

Merge #11200: Allow for aborting rescans in the GUI

Summary:
ae1d2b030 Give an error when rescan is aborted by the user (Andrew Chow)
69b01e6f8 Add cancel button to rescan progress dialog (Andrew Chow)

Pull request description:

A cancel button is added to the `showProgress` dialog that is used only for rescans. When clicked, `AbortRescan` is called directly to cancel the rescan.

Rescans triggered from the debug console will now be cancelable by clicking the cancel button.

Rescans triggered by a command (e.g. `importmulti`) will now give an error indicating that the rescan was aborted by the user (either by the `abortrescan` command or by clicking cancel).

Tree-SHA512: 4bb14998766de686e2318fbc9805758eccf5dbe628a7257d072c9ae2fb4f61303a0876f49988d6e5eddb261969b8a307c81c0c2df0a42ae909a43d738af3dc1b

Backport of Core PR11200
https://github.com/bitcoin/bitcoin/pull/11200/

Test Plan:

make check
./bitcoin-qt -> help -> debug -> console -> rescanblockchain -> select cancel in the new window.

Reviewers: deadalnix, Fabien, jasonbcox, O1 Bitcoin ABC, #bitcoin_abc

Reviewed By: Fabien, O1 Bitcoin ABC, #bitcoin_abc

Differential Revision: https://reviews.bitcoinabc.org/D3891

Details

Committed
Nico Guiton <nico@bitframe.org>Aug 16 2019, 21:59
Pushed
nakihitoAug 16 2019, 21:59
Reviewer
Restricted Owners Package
Differential Revision
D3891: Merge #11200: Allow for aborting rescans in the GUI
Parents
rABC03bdf2f3aed8: Merge #12837: rpc: fix type mistmatch in `listreceivedbyaddress`
Branches
Unknown
Tags
Unknown

Event Timeline