HomePhabricator

[Cashtab] Do not specify change address in getSlpGenesisTargetOutput

Description

[Cashtab] Do not specify change address in getSlpGenesisTargetOutput

Summary:
Standard API in ecash-coinselect is to create change outputs with no specified address. So, Cashtab already handles these outputs by adding Cashtab's expected change address, which is the Path1899 address.

We should not be hardcoding this into only 1 of our many specialty tx building functions. It should follow this existing standard.

Test Plan: npm test

Reviewers: #bitcoin_abc, emack

Reviewed By: #bitcoin_abc, emack

Differential Revision: https://reviews.bitcoinabc.org/D15958

Details

Provenance
bytesofmanAuthored on Apr 12 2024, 12:51
bytesofmanPushed on Apr 12 2024, 13:47
Reviewer
Restricted Project
Differential Revision
D15958: [Cashtab] Do not specify change address in getSlpGenesisTargetOutput
Parents
rABCdde4f83cd5d0: [explorer] Simplify JsonToken
Branches
Unknown
Tags
Unknown