HomePhabricator

Increase timeout in wallet_multiwallet

Description

Increase timeout in wallet_multiwallet

Summary:
The test occasionally fails on got_loading_error = False on the slow qemu machines. There are only 3 ways this can fail: a timeout occured, an unhandled JSONRPCError is raised, or the race didn't happen.
The later case should be rare enough that it never happens, intended that the tests runs the RPCs enough times
This is where this becomes problematic, as we have a timeout that doesn't scale with the RPC duration. This diff fixes that by ensuring that each of the 2 RPCs in test_load_unload can run 10x at timeout duration. That will also fixes the first case as RPC timeout can be greater than the thread timeout without this diff.

Depends on D12215.

Test Plan:

./test/functional/test_runner.py wallet_multiwallet

Reviewers: #bitcoin_abc, PiRK

Reviewed By: #bitcoin_abc, PiRK

Differential Revision: https://reviews.bitcoinabc.org/D12216

Details

Provenance
FabienAuthored on Oct 12 2022, 10:43
FabienPushed on Oct 12 2022, 16:07
Reviewer
Restricted Project
Differential Revision
D12216: Increase timeout in wallet_multiwallet
Parents
rABC6df79e15c60c: test: add tests for bad-txns-prevout-null reject reason
Branches
Unknown
Tags
Unknown