HomePhabricator

[validation] return effective feerate from mempool validation

Description

[validation] return effective feerate from mempool validation

Summary:
Partial backport of core#26646:
https://github.com/bitcoin/bitcoin/pull/26646/commits/1605886380e4d3ff2e1236739fb800fa07322c49

This includes some code from https://github.com/bitcoin/bitcoin/pull/24152/commits/51edcffa0e156dba06191a8d5c636ba01fa5b65f
that was skipped during the backport of core#24152 because the test case was segwit related.
Some of the code was later reintroduced to create a non-segwit test for checking tx deduplication, and we need to add back
the relevant skipped changes to check the correct behavior here: if parent2 is not 0-fee, then it's valid according to the
mempool policy and so the package feerate is not computed (all txs being individually compliant, there is no reason to
check the package feerate).

Depends on D16395.

Test Plan:

ninja all check-all

Reviewers: #bitcoin_abc, roqqit

Reviewed By: roqqit

Differential Revision: https://reviews.bitcoinabc.org/D16396

Details

Provenance
glozow <gloriajzhao@gmail.com>Authored on Sep 28 2022, 10:23
FabienCommitted on Tue, Jul 2, 07:21
FabienPushed on Tue, Jul 2, 07:21
Reviewer
roqqit
Differential Revision
D16396: [validation] return effective feerate from mempool validation
Parents
rABC1796fad75bd4: package validation quits early due to non-policy, non-missing-inputs failure
Branches
Unknown
Tags
Unknown