HomePhabricator

p2p: clean up Misbehaving()

Description

p2p: clean up Misbehaving()

Summary:

This PR makes a few minor clean-ups to Misbehaving() in preparation to
move it out of the cs_main lock.

There are very minor logging changes but otherwise no functional
changes.

Backport of core PR19583.

Depends on D8792.

Some of our Misbehaving messages are updated to match core messages.

Test Plan:

ninja all check-all

Reviewers: #bitcoin_abc, majcosta

Reviewed By: #bitcoin_abc, majcosta

Subscribers: majcosta

Differential Revision: https://reviews.bitcoinabc.org/D8793

Details

Provenance
John Newbery <john@johnnewbery.com>Authored on Jul 24 2020, 07:03
FabienCommitted on Jan 6 2021, 11:02
FabienPushed on Jan 6 2021, 11:04
Reviewer
Restricted Project
Differential Revision
D8793: p2p: clean up Misbehaving()
Parents
rABC7749e8d4b3f2: [net processing] Reduce cs_main scope in MaybeDiscourageAndDisconnect()
Branches
Unknown
Tags
Unknown

Event Timeline