HomePhabricator

Improving labels for Sent / Received "Bytes"
7ca73dcf6b7eUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Improving labels for Sent / Received "Bytes"

The labels for Sent & Received data in the "Peers" debug panel should not be defined as "Bytes" because the units (B, KB, MB) appear after the number. I decided to simply use "Sent" and "Received" (rather than "Data Sent" and "Data Received") because we already have translations for the former:
https://www.transifex.com/bitcoin/bitcoin/viewstrings/#ja/qt-translation-011x/47533089?q=sent
https://www.transifex.com/bitcoin/bitcoin/viewstrings/#ja/qt-translation-011x/47533089?q=received

Demo of changes:

Current UI:

    Bytes Sent      12 KB
    Bytes Received  26 MB

With this pull request:

Sent       12 KB
Received   26 MB

Details

Provenance
Jonathan Cross <jonathancross@users.noreply.github.com>Authored on Nov 4 2015, 19:14
deadalnixPushed on May 14 2017, 22:04
Parents
rABC193f7b553e0a: Merge pull request #6938
Branches
Unknown
Tags
Unknown

Event Timeline

Jonathan Cross <jonathancross@users.noreply.github.com> committed rABC7ca73dcf6b7e: Improving labels for Sent / Received "Bytes" (authored by Jonathan Cross <jonathancross@users.noreply.github.com>).Nov 4 2015, 19:14