HomePhabricator

Fix undefined behaviour errors due to long int overflow in Amount

Authored by Fabien on Dec 7 2018, 14:52.

Description

Fix undefined behaviour errors due to long int overflow in Amount

Summary:
Running the units tests with the undefined behaviour sanitizer throws
runtime errors: signed integer overflow in file amount.h.
This is due to the INF_PRIORITY constant, which is no longer used in the
software. It can be safely removed.

Test Plan:
Build with the undefined sanitizer enabled then

./src/test/test_bitcoin

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Subscribers: teamcity, schancel

Differential Revision: https://reviews.bitcoinabc.org/D2179

Details

Committed
FabienDec 7 2018, 20:51
Pushed
FabienDec 7 2018, 20:51
Reviewer
Restricted Project
Differential Revision
D2179: Fix undefined behaviour errors due to long int overflow in Amount
Parents
rABC96ad4ca52218: Make links clickable in CONTRIBUTING.md
Branches
Unknown
Tags
Unknown