scripted-diff: tree-wide: Remove all review-only assertions
Summary:
-BEGIN VERIFY SCRIPT- find_regex='(assert|CHECK_NONFATAL)\(std::addressof' git grep -l -E "$find_regex" -- . | xargs sed -i -E "/${find_regex}[^;]+;/d" git grep -l -E "$find_regex" -- . | xargs sed -i -E "/${find_regex}/,/;/d" git grep -l -E "TODO: REVIEW-ONLY" -- . | xargs sed -i -E "/TODO: REVIEW-ONLY/,/;/d" -END VERIFY SCRIPT-
Note: the script first removes assertions that are on a single line, then removes the multiline assertions by using the ";" character as the end delimiter.
This is a backport of core#21866 [10/12]
https://github.com/bitcoin/bitcoin/pull/21866/commits/6c3b5dc0c13c3ac8c6e86298f924abe99d8d6bd1
Depends on D11685
Test Plan: ninja all check-all bitcoin-bench
Reviewers: #bitcoin_abc, Fabien
Reviewed By: #bitcoin_abc, Fabien
Differential Revision: https://reviews.bitcoinabc.org/D11686