HomePhabricator

[SECP256K1] [RFC] Remove OpenSSL testing support

Description

[SECP256K1] [RFC] Remove OpenSSL testing support

Summary:

This removes the ability to test against OpenSSL, as well as the OpenSSL verification benchmark.

The motivation is that OpenSSL 3 is deprecating part of the API used here (see #869), and I'm not sure it's worth maintaining. We do lose the fact that this is the only test that verifies randomly-generated cases against an independent implementation. On the other hand, there are tons of existing fixed tests now that test all kinds of edge cases already.

Backport of secp256k1#983.

This fixes the issue https://github.com/Bitcoin-ABC/secp256k1/issues/1

Test Plan:

ninja check-secp256k1

Check there is no remaining use:

git grep ENABLE_OPENSSL_TESTS

Reviewers: #bitcoin_abc, PiRK

Reviewed By: #bitcoin_abc, PiRK

Differential Revision: https://reviews.bitcoinabc.org/D11135

Details

Provenance
Pieter Wuille <pieter@wuille.net>Authored on Sep 28 2021, 20:41
FabienCommitted on Mar 6 2022, 21:04
FabienPushed on Mar 6 2022, 21:04
Reviewer
Restricted Project
Differential Revision
D11135: [SECP256K1] [RFC] Remove OpenSSL testing support
Parents
rABC29d401ca0636: Migrate seeder to use node's sleep utility function
Branches
Unknown
Tags
Unknown