HomePhabricator

Log debug build status and warn when running benchmarks

Description

Log debug build status and warn when running benchmarks

Summary:
"34328b4 Use PACKAGE_NAME instead of hardcoding application name in log message (Wladimir J. van der Laan)
0c74e2e Log debug build status and warn when running benchmarks (Wladimir J. van der Laan)

Pull request description:

Log whether the starting instance of bitcoin core is a debug or release build (--enable-debug).

Also warn when running the benchmarks with a debug build, to prevent mistakes comparing debug to non-debug results."

This is a backport from Core PR12197: https://github.com/bitcoin/bitcoin/pull/12197

Test Plan:

cmake .. -DCMAKE_BUILD_TYPE=Debug -GNinja
ninja check
ninja bench-bitcoin

Reviewers: O1 Bitcoin ABC, #bitcoin_abc, deadalnix, nakihito, Fabien

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, nakihito, Fabien

Subscribers: Fabien, nakihito

Differential Revision: https://reviews.bitcoinabc.org/D4687

Details

Provenance
Wladimir J. van der Laan <laanwj@gmail.com>Authored on Jan 29 2018, 10:12
majcostaCommitted on Dec 10 2019, 22:03
majcostaPushed on Dec 10 2019, 22:04
Reviewer
Restricted Owners Package
Differential Revision
D4687: Log debug build status and warn when running benchmarks
Parents
rABCbb10be36f20f: bench_bitcoin: Avoid read/write to default datadir
Branches
Unknown
Tags
Unknown