HomePhabricator

[land-bot] Clarify review status error message

Description

[land-bot] Clarify review status error message

Summary:
This clarifies the error message in less-common cases such as
when a revision has already been landed. Prior to this patch,
it appears as if the revision was never reviewed at all. It's best
that we provide the review status to the user so they can make
a judgement of what the root cause is.

Test Plan:

CONDUIT_TOKEN=<token> ./land-patch.sh -r D6379

Outputs:

Error: Revision 'D6379' is not accepted. Review status is: "published"

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D6388

Details

Provenance
jasonbcoxAuthored on Jun 5 2020, 18:00
jasonbcoxPushed on Jun 5 2020, 20:29
Reviewer
Restricted Project
Differential Revision
D6388: [land-bot] Clarify review status error message
Parents
rABC8792ff7cef71: Batch write imported stuff in importmulti
Branches
Unknown
Tags
Unknown