HomePhabricator

Reapply "gui: Do not exit and re-enter main event loop during shutdown"

Description

Reapply "gui: Do not exit and re-enter main event loop during shutdown"

Summary:
Un-revert D18150 + apply a bugfix for a MacOS crash on shutdown:

core-gui#547

qt: Override BitcoinApplication::event() to handle QEvent::Quit

#336 introduced a regression when termination requests from a platform are not handled properly.

This PR fixes this regression. On macOS shutdown after clicking "Quit" in Dock icon menu, and during logout works again.

This concludes backport of core-gui#336 and core-gui#547

Test Plan: test plan of D18150 + run bitcoin-qt on MacOS

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D18170

Details

Provenance
PiRKAuthored on May 29 2025, 13:42
PiRKPushed on May 31 2025, 06:15
Reviewer
Restricted Project
Differential Revision
D18170: Reapply "gui: Do not exit and re-enter main event loop during shutdown"
Parents
rABCba5ee5acf062: [e.cash] Capitalize Internet for v2 site
Branches
Unknown
Tags
Unknown
Reverts
D18150: gui: Do not exit and re-enter main event loop during shutdown