HomePhabricator

Fix unused -pie flag for libs

Description

Fix unused -pie flag for libs

Summary:
Before cmake 3.14, the -pie linker flag needs to be added manually. It
is currently applied to all targets, despite it is only useful when
linking exectuables. This causes clang to raise a
-Wunused-command-line-argument warning. This diff filters the -pie
flag better to get rid of this warning.

Test Plan:
With clang as a compiler:

ninja all security-check

Check the warning is gone.

Reviewers: #bitcoin_abc, majcosta

Reviewed By: #bitcoin_abc, majcosta

Differential Revision: https://reviews.bitcoinabc.org/D6281

Details

Provenance
FabienAuthored on May 28 2020, 15:13
FabienPushed on May 29 2020, 07:38
Reviewer
Restricted Project
Differential Revision
D6281: Fix unused -pie flag for libs
Parents
rABCca058e052725: [Automated] Update manpages
Branches
Unknown
Tags
Unknown