HomePhabricator

Fix the functional tests on platforms using select() instead of poll()

Description

Fix the functional tests on platforms using select() instead of poll()

Summary:
On such platforms the select() interface limits the number of file
descriptors to FD_SETSIZE, which is usually 1024. Since D8605 the
default value for -maxconnections is 4096, which cannot be reached.

Therefore the software will output a warning to tell the user that the
max connections is being reduced due to system limitation. This used to
be a special case before D8605 and required manually setting
-maxconnections, but this is no longer the case. As a consequence this
warning causes the functional tests to fail, because they expect stderr
to be empty.

Since this is a normal behavior, this diff downgrades the warning to a
standard log line. The documentation is updated to inform the user that
this value might not be reachable if set manually.

Test Plan:
On Linux and OSX:

ninja check-functional

Reviewers: #bitcoin_abc, majcosta

Reviewed By: #bitcoin_abc, majcosta

Differential Revision: https://reviews.bitcoinabc.org/D8628

Details

Provenance
FabienAuthored on Dec 8 2020, 13:53
FabienPushed on Dec 8 2020, 14:36
Reviewer
Restricted Project
Differential Revision
D8628: Fix the functional tests on platforms using select() instead of poll()
Parents
rABC3b83c27d9a15: [backport#16400] refactor: Rewrite AcceptToMemoryPoolWorker() using smaller…
Branches
Unknown
Tags
Unknown