HomePhabricator

test: use MiniWallet for p2p_filter.py

Description

test: use MiniWallet for p2p_filter.py

Summary:

This PR enables one more of the non-wallet functional tests (p2p_filter.py) to be run even with the Bitcoin Core wallet disabled by using the MiniWallet instead, as proposed in #20078.
For this purpose, a MiniWallet method send_to is introduced first, which allows to create arbitrary outputs (scriptPubKey/amount). Note that the implementation for this is already present in feature_rbf.py (recently added in PR #22998), i.e. it is simply moved to the MiniWallet interface.

Backport of core#23079.

Also cherry-picked a required change from core#22998 that returns the txid from the wallet sendrawtransaction.

Test Plan:

ninja check-all

Reviewers: #bitcoin_abc, sdulfari

Reviewed By: #bitcoin_abc, sdulfari

Differential Revision: https://reviews.bitcoinabc.org/D12729

Details

Provenance
Sebastian Falbesoner <sebastian.falbesoner@gmail.com>Authored on Sep 23 2021, 23:01
FabienCommitted on Dec 2 2022, 19:42
FabienPushed on Dec 2 2022, 19:42
Reviewer
Restricted Project
Differential Revision
D12729: test: use MiniWallet for p2p_filter.py
Parents
rABC5a3533806edc: [Linter] Fix all the lint warnings
Branches
Unknown
Tags
Unknown

Event Timeline