HomePhabricator

[backport#16033] Hold cs_main when reading chainActive via getTipLocator().

Description

[backport#16033] Hold cs_main when reading chainActive via getTipLocator(). Remove assumeLocked()

Summary:
https://github.com/bitcoin/bitcoin/pull/16033/commits/593a8e8a2ce177c41a7809479c0086ae0fee4b4e wallet: Use chain.lock() instead of temporary chain.assumeLocked()
https://github.com/bitcoin/bitcoin/pull/16033/commits/9402ef0739fdcd8e989c07c0595095e9608b243c Remove temporary method assumeLocked(). Remove LockingStateImpl. Remove redundant cs_main locks.


This is a backport of Core PR16033

Test Plan:

ninja check

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Subscribers: deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D6132

Details

Provenance
practicalswift <practicalswift@users.noreply.github.com>Authored on May 16 2019, 19:43
majcostaCommitted on May 19 2020, 13:19
majcostaPushed on May 19 2020, 13:19
Reviewer
Restricted Project
Differential Revision
D6132: [backport#16033] Hold cs_main when reading chainActive via getTipLocator(). Remove assumeLocked()
Parents
rABC6d6a8b346ccb: Switch memory_cleanse implementation to BoringSSL's
Branches
Unknown
Tags
Unknown