HomePhabricator

[avalanche] Don't check the delegation in the peer manager

Description

[avalanche] Don't check the delegation in the peer manager

Summary:
The PeerManager::addNode() actually checks the delegation for the
node. This is node the right place to do the check since the peer
manager don't use the delegation ever but only the proof id, and also
doesn't return a proper error message in case of failure. This check is
already performed at the avahello reception which will be the main
callsite for this addNode() method.

Depends on D9719.

Ref T1634.

Test Plan:

ninja all check-all

Reviewers: #bitcoin_abc, PiRK

Reviewed By: #bitcoin_abc, PiRK

Maniphest Tasks: T1634

Differential Revision: https://reviews.bitcoinabc.org/D9720

Details

Provenance
FabienAuthored on Jun 30 2021, 19:05
FabienPushed on Jul 7 2021, 09:48
Reviewer
Restricted Project
Differential Revision
D9720: [avalanche] Don't check the delegation in the peer manager
Parents
rABCe8c27824099b: [avalanche] Move the pubkey storage from the node to the network layer
Branches
Unknown
Tags
Unknown
Tasks
Restricted Maniphest Task