HomePhabricator

Enable flake8 warnings for all currently non-violated rules

Description

Enable flake8 warnings for all currently non-violated rules

Summary:
Also include an unrelated variable rename:
Fix accidental redefinition via list comprehension
to be in par with core as it is part of the PR.

I removed W504 as it conflicts with autopep8, and W605 as it throws a lot of warnings. They will be
fixed and added in follow-ups to not bloat this diff.

Backport of core PR12295
https://github.com/bitcoin/bitcoin/pull/12295/files

Test Plan:

arc lint --everything

Reviewers: #bitcoin_abc, deadalnix, jasonbcox

Reviewed By: #bitcoin_abc, jasonbcox

Differential Revision: https://reviews.bitcoinabc.org/D3461

Details

Provenance
FabienAuthored on Jun 28 2019, 14:28
FabienPushed on Jun 28 2019, 17:46
Reviewer
Restricted Project
Differential Revision
D3461: Enable flake8 warnings for all currently non-violated rules
Parents
rABC7f3aff678445: qa: Add missing syncwithvalidationinterfacequeue to tests
Branches
Unknown
Tags
Unknown