HomePhabricator

refactor: make MainSignalsInstance() a class, rename it to MainSignalsImpl

Description

refactor: make MainSignalsInstance() a class, rename it to MainSignalsImpl

Summary:

refactor: make MainSignalsInstance() a class

Context:

MainSignalsInstance was originally a struct collection of boost::signals methods moved to validationinterface.cpp, in order to no longer need to include boost/signals in validationinterface.h.

MainSignalsInstance then evolved to remove boost/signals2 and became class-like.

C.8: Use class rather than struct if any member is non-public

C.2: Use class if the class has an invariant; use struct if the data members can vary independently

A class also has the advantage of default private access, as opposed to public for a struct.

refactor: remove unused forward declarations in validationinterface.h

Rename MainSignalsInstance() class to MainSignalsImpl()

This is a backport of core#25067

Test Plan: ninja all check-all

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D13265

Details

Provenance
Jon Atack <jon@atack.com>Authored on May 3 2022, 16:34
PiRKCommitted on Mar 10 2023, 11:55
PiRKPushed on Mar 10 2023, 11:56
Reviewer
Restricted Project
Differential Revision
D13265: refactor: make MainSignalsInstance() a class, rename it to MainSignalsImpl
Parents
rABCcc1436368f5b: [cmake] Disable ABI changes warnings
Branches
Unknown
Tags
Unknown