HomePhabricator

[avalanche] Only re-add contenders to the cache if the remote proof is present

Description

[avalanche] Only re-add contenders to the cache if the remote proof is present

Summary:
While debugging D18003 I discovered that the last old_quorum proof was being re-added to the cache unexpectedly. The tests would pass due to incomplete test coverage. This diff fixes both of these.

Depends on D18011

Test Plan:

ninja check
./test/functional/test_runner.py abc_p2p_avalanche_contender_voting

Reviewers: #bitcoin_abc, PiRK

Reviewed By: #bitcoin_abc, PiRK

Differential Revision: https://reviews.bitcoinabc.org/D18013

Details

Provenance
roqqitAuthored on Mon, Apr 28, 22:14
roqqitPushed on Tue, Apr 29, 18:53
Reviewer
Restricted Project
Differential Revision
D18013: [avalanche] Only re-add contenders to the cache if the remote proof is present
Parents
rABC4a35b7c33298: [avalanche] Correctly check if a contender is associated with a remote proof
Branches
Unknown
Tags
Unknown