Differential D18013

[avalanche] Only re-add contenders to the cache if the remote proof is present
ClosedPublic
Actions

Authored by roqqit on Mon, Apr 28, 23:53.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC8ebbda579e21: [avalanche] Only re-add contenders to the cache if the remote proof is present

Summary

While debugging D18003 I discovered that the last old_quorum proof was being re-added to the cache unexpectedly. The tests would pass due to incomplete test coverage. This diff fixes both of these.

Depends on D18011

Test Plan

ninja check
./test/functional/test_runner.py abc_p2p_avalanche_contender_voting

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

roqqit created this revision.Mon, Apr 28, 23:53

Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Apr 28, 23:53

roqqit requested review of this revision.Mon, Apr 28, 23:53

Harbormaster completed remote builds in B33143: Diff 53739.Tue, Apr 29, 00:00

PiRK accepted this revision.Tue, Apr 29, 06:38

This revision is now accepted and ready to land.Tue, Apr 29, 06:38

Closed by commit rABC8ebbda579e21: [avalanche] Only re-add contenders to the cache if the remote proof is present (authored by roqqit). · Explain WhyTue, Apr 29, 18:53

This revision was automatically updated to reflect the committed changes.

roqqit added a commit: rABC8ebbda579e21: [avalanche] Only re-add contenders to the cache if the remote proof is present.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

peermanager.cpp

2 lines

test/

functional/

abc_p2p_avalanche_contender_voting.py

42 lines

Diff 53774

View Options

src/avalanche/peermanager.cpp