HomePhabricator

Merge #10655: Properly document target_confirmations in listsinceblock

Description

Merge #10655: Properly document target_confirmations in listsinceblock

Summary:
PR10655 backport https://github.com/bitcoin/bitcoin/pull/10655/files
9f8a46f Properly document target_confirmations in listsinceblock (Ryan Havar)

Pull request description:

There seems to be some misunderstandings about this, but it's a heavily used function so I'd like to make sure the docs are clear about how it works.

For a later issue:
* Change the default of target_confirmations to 6  (1 is a pretty silly default)
* Change the name of target_confirmations (it's really a horrible name)

Test Plan:
make check
read

Reviewers: deadalnix, jasonbcox, Fabien, #bitcoin_abc

Reviewed By: deadalnix, #bitcoin_abc

Differential Revision: https://reviews.bitcoinabc.org/D3478

Details

Provenance
Wladimir J. van der Laan <laanwj@gmail.com>Authored on Jun 30 2019, 23:19
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>Committed on Jun 30 2019, 23:20
markblundebergPushed on Jun 30 2019, 23:20
Reviewer
Restricted Project
Differential Revision
D3478: Merge #10655: Properly document target_confirmations in listsinceblock
Parents
rABC5be0cb874c80: Add unit tests for signals generated by ProcessNewBlock()
Branches
Unknown
Tags
Unknown