test: Create InsecureRandMoneyAmount() helper, de-duplicate add_coin methods
9006f52c6661
Actions

Description

test: Create InsecureRandMoneyAmount() helper, de-duplicate add_coin methods

Summary:
Generate semi-random Amounts up to MAX_MONEY rather than only uint32, and use it in the unit tests.

This concludes backport of core#26490
https://github.com/bitcoin/bitcoin/pull/26940/commits/9d92c3d7f42c18939a9a6aa1ee185f1c958360a0
https://github.com/bitcoin/bitcoin/pull/26940/commits/4275195606e6f42466d9a8ef766b3035833df4d5

Depends on D16155

Test Plan: ninja check

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D16156

Details

Provenance

PiRK	Authored on May 14 2024, 13:06
PiRK	Pushed on May 16 2024, 11:57

Reviewer

Restricted Project

Differential Revision

D16156: test: Create InsecureRandMoneyAmount() helper, de-duplicate add_coin methods

Parents

rABC4d970e2fdeef: Move random test util code from setup_common to random

Branches

Unknown

Tags

Unknown

Event Timeline

PiRK committed rABC9006f52c6661: test: Create InsecureRandMoneyAmount() helper, de-duplicate add_coin methods (authored by PiRK).May 16 2024, 11:57

PiRK added an edge: D16156: test: Create InsecureRandMoneyAmount() helper, de-duplicate add_coin methods.

teamcity mentioned this in T3575: Build Bitcoin-ABC / Nightly Builds / Initial Block Download Tests / Initial Block Download w/o Checkpoints is broken..May 17 2024, 14:08

Changes (8)

Path

Size

src/

test/

util/

validation_chainstate_tests.cpp

validation_flush_tests.cpp

rABC9006f52c6661

View Options

src/test/CMakeLists.txt

View Options

src/test/coins_tests.cpp

View Options

src/test/sighash_tests.cpp

View Options

src/test/util/coins.cpp

View Options

src/test/util/coins.h

View Options

src/test/util/random.h

View Options

src/test/validation_chainstate_tests.cpp

View Options

src/test/validation_flush_tests.cpp

test: Create InsecureRandMoneyAmount() helper, de-duplicate add_coin methods9006f52c6661Actions

Description

Details

Event Timeline

Changes (8)

rABC9006f52c6661

src/test/CMakeLists.txt

src/test/coins_tests.cpp

src/test/sighash_tests.cpp

src/test/util/coins.cpp

src/test/util/coins.h

src/test/util/random.h

src/test/validation_chainstate_tests.cpp

src/test/validation_flush_tests.cpp

test: Create InsecureRandMoneyAmount() helper, de-duplicate add_coin methods
9006f52c6661
Actions