Merge #14409: utils and libraries: Make 'blocksdir' always net specific
9044d3d396df
Actions

Description

Merge #14409: utils and libraries: Make 'blocksdir' always net specific

Summary:
PR14409 backport https://github.com/bitcoin/bitcoin/pull/14409/files
e4a0c3547ed886871f8b3d51c6b4ffdb181a8b9c Improve blocksdir functional test. (Hennadii Stepanov)
c3f1821ac788e522e7558e3575150433450dcb8c Make blockdir always net specific (Hennadii Stepanov)

Pull request description:

The blocks directory is net specific by definition.

Also this prevents the side effect of calling `GetBlocksDir(false)` in the non-mainnet environment.
Currently a new node creates an unused `blocks\` directory in the root of the data directory when `-testnet` or `-regtest` is specified.

Depends on D3312

Test Plan:
make check
test_runner.py

Reviewers: jasonbcox, Fabien, #bitcoin_abc, deadalnix

Reviewed By: Fabien, #bitcoin_abc

Differential Revision: https://reviews.bitcoinabc.org/D3076

Details

Provenance

Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>	Authored on Jun 10 2019, 22:01
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>	Committed on Jun 15 2019, 20:16
markblundeberg	Pushed on Jun 15 2019, 20:16

Reviewer

Restricted Project

Differential Revision

D3076: Merge #14409: utils and libraries: Make 'blocksdir' always net specific

Parents