HomePhabricator

wallet: Avoid use of Chain::Lock in importprunedfunds

Description

wallet: Avoid use of Chain::Lock in importprunedfunds

Summary:
This is a step toward removing the Chain::Lock class and reducing cs_main
locking.

This change only affects behavior in the case where wallet last block processed
falls behind the chain tip, in which case the "Block not found in chain" error
will be stricter and not allow importing data from a blocks between the wallet
last processed tip and the current node tip.

This is part [4/12] of Core PR17954 : https://github.com/bitcoin/bitcoin/pull/17954/commits/c1694ce6bb7e19a8722d5583cd85ad17da40bb67

Depends on D7866

Test Plan:

ninja all check

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D7867

Details

Provenance
Russell Yanofsky <russ@yanofsky.org>Authored on Jan 16 2020, 21:38
deadalnixCommitted on Oct 11 2020, 12:24
deadalnixPushed on Oct 11 2020, 12:24
Reviewer
Restricted Project
Differential Revision
D7867: wallet: Avoid use of Chain::Lock in importprunedfunds
Parents
rABC06409d3c3413: wallet refactor: Avoid use of Chain::Lock in qt wallettests
Branches
Unknown
Tags
Unknown