HomePhabricator

[backport#15136] qt: "Peers" tab overhaul

Description

[backport#15136] qt: "Peers" tab overhaul

Summary:
3537c8345c788a527bb4e1d00683ca7f8ee5fb1a Do not deselect peer when switching away from tab (Hennadii Stepanov)
b0037c51909dc55e279baa81f063c169c9735105 Improve Peers tab layout (Hennadii Stepanov)

Pull request description:

This is an alternative to #14798.

The "Peers" tab of the "Debug" window improved to address comments https://github.com/bitcoin/bitcoin/pull/6209#issuecomment-108072605 (by @jonasschnelli) and https://github.com/bitcoin/bitcoin/pull/14798#issuecomment-441618268 (by @promag).

This allows to keep the peer selection while navigating to other places and effectively reverts e0597268116cf90d961abeba9d14aaad0ab682d2.

Screenshots with this PR:
![screenshot from 2019-01-09 22-01-36](https://user-images.githubusercontent.com/32963518/50927352-2e6fb700-1460-11e9-9173-582348210492.png)
![screenshot from 2019-01-09 22-02-11](https://user-images.githubusercontent.com/32963518/50927354-329bd480-1460-11e9-9926-d0eb0f026a35.png)
![screenshot from 2019-01-09 22-02-37](https://user-images.githubusercontent.com/32963518/50927358-3596c500-1460-11e9-864d-c8704451f3d9.png)

Backport of Core PR15136

Test Plan:

ninja all
./qt/bitcoin-qt -testnet

check out the Peers tab for correctness

Reviewers: #bitcoin_abc, PiRK

Reviewed By: #bitcoin_abc, PiRK

Differential Revision: https://reviews.bitcoinabc.org/D8547

Details

Provenance
Wladimir J. van der Laan <laanwj@gmail.com>Authored on Jan 16 2019, 11:37
majcostaCommitted on Nov 28 2020, 20:32
majcostaPushed on Nov 28 2020, 20:32
Reviewer
Restricted Project
Differential Revision
D8547: [backport#15136] qt: "Peers" tab overhaul
Parents
rABC1e1bd99a6435: [backport#14594] qt: Fix minimized window bug on Linux
Branches
Unknown
Tags
Unknown
Reverts
rABCe0597268116c: [Qt] deselect peer when switching away from peers tab in RPC console