HomePhabricator

Remove CCoinsViewCache::GetValueIn(...)

Description

Remove CCoinsViewCache::GetValueIn(...)

Summary:

Fixes #18858.

It seems like GetValueIn was added in PR748 ("Pay-to-script-hash (OP_EVAL replacement)", merged in 2012) and the last use in validation code was removed in PR8498 ("Near-Bugfix: Optimization: Minimize the number of times it is checked that no money...", merged in 2017).

This is a backport of Core PR18859

Test Plan: nja all check-all`

Reviewers: #bitcoin_abc, majcosta

Reviewed By: #bitcoin_abc, majcosta

Differential Revision: https://reviews.bitcoinabc.org/D9071

Details

Provenance
practicalswift <practicalswift@users.noreply.github.com>Authored on Jan 27 2021, 07:43
PiRKCommitted on Jan 27 2021, 07:44
abc-botPushed on Jan 27 2021, 07:50
Reviewer
Restricted Project
Differential Revision
D9071: Remove CCoinsViewCache::GetValueIn(...)
Parents
rABC635ba981570b: test: Fix p2p_leak intermittent issue
Branches
Unknown
Tags
Unknown