HomePhabricator

gui: Drop PeerTableModel dependency to ClientModel

Description

gui: Drop PeerTableModel dependency to ClientModel

Summary:

Class PeerTableModel doesn't actually depend on ClientModel.

This removes the circular dependency qt/clientmodel -> qt/peertablemodel -> qt/clientmodel

This is a backport of Core PR18060

Test Plan:
ninja && src/qt/bitcoin-qt

PeerTableModel is used in the rpc console GUI.

test/lint/lint-circular-dependencies.sh

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D8737

Details

Provenance
João Barbosa <joao.paulo.barbosa@gmail.com>Authored on Dec 22 2020, 14:10
PiRKCommitted on Dec 22 2020, 14:10
abc-botPushed on Dec 22 2020, 14:16
Reviewer
Restricted Project
Differential Revision
D8737: gui: Drop PeerTableModel dependency to ClientModel
Parents
rABCbc14a0e2b803: Walk pindexBestHeader back to ChainActive().Tip() if it is invalid
Branches
Unknown
Tags
Unknown