scripted-diff: TxoutType C++11 scoped enum class
97c446e3bf66
Actions

Description

scripted-diff: TxoutType C++11 scoped enum class

Summary:

Non-scoped enums can accidentally and silently decay into an integral
type. Also, the symbol names of the keys are exported to the surrounding
(usually global) namespace.

Fix both issues by switching to an enum class TxoutType in a (mostly)
scripted-diff.

Backport of core PR19114.

Depends on D9124.

Test Plan:

ninja all check-all
ninja bitcoin-fuzzers

Reviewers: #bitcoin_abc, majcosta

Reviewed By: #bitcoin_abc, majcosta

Subscribers: PiRK

Differential Revision: https://reviews.bitcoinabc.org/D9126

Details

Provenance

MarcoFalke <falke.marco@gmail.com>	Authored on May 30 2020, 14:11
Fabien	Committed on Feb 2 2021, 07:37
Fabien	Pushed on Feb 2 2021, 07:38

Reviewer

Restricted Project

Differential Revision

D9126: scripted-diff: TxoutType C++11 scoped enum class

Parents

rABCd56bef9201d0: refactor: Replace const char* to std::string

Branches

Unknown

Tags

Unknown

Event Timeline

Fabien committed rABC97c446e3bf66: scripted-diff: TxoutType C++11 scoped enum class (authored by MarcoFalke <falke.marco@gmail.com>).Feb 2 2021, 07:37

Fabien added an edge: D9126: scripted-diff: TxoutType C++11 scoped enum class.

Changes (18)

Path

Size

src/

policy/

rpc/

script/

test/

fuzz/

key.cpp

script.cpp

multisig_tests.cpp

script_standard_tests.cpp

transaction_tests.cpp

util/

wallet/

rABC97c446e3bf66

View Options

src/bloom.cpp

View Options

src/core_write.cpp

View Options

src/policy/policy.cpp

View Options

src/policy/policy.h

View Options

src/rpc/rawtransaction.cpp

View Options

src/script/descriptor.cpp

View Options

src/script/sign.cpp

View Options

src/script/standard.cpp

View Options

src/script/standard.h

View Options

src/test/fuzz/key.cpp

View Options

src/test/fuzz/script.cpp

View Options

src/test/multisig_tests.cpp

View Options

src/test/script_standard_tests.cpp

View Options

src/test/transaction_tests.cpp

View Options

src/test/util/transaction_utils.h

View Options

src/wallet/rpcdump.cpp

View Options

src/wallet/rpcwallet.cpp

View Options

src/wallet/scriptpubkeyman.cpp

scripted-diff: TxoutType C++11 scoped enum class97c446e3bf66Actions

Description

Details

Event Timeline

Changes (18)

rABC97c446e3bf66

src/bloom.cpp

src/core_write.cpp

src/policy/policy.cpp

src/policy/policy.h

src/rpc/rawtransaction.cpp

src/script/descriptor.cpp

src/script/sign.cpp

src/script/standard.cpp

src/script/standard.h

src/test/fuzz/key.cpp

src/test/fuzz/script.cpp

src/test/multisig_tests.cpp

src/test/script_standard_tests.cpp

src/test/transaction_tests.cpp

src/test/util/transaction_utils.h

src/wallet/rpcdump.cpp

src/wallet/rpcwallet.cpp

src/wallet/scriptpubkeyman.cpp

scripted-diff: TxoutType C++11 scoped enum class
97c446e3bf66
Actions