HomePhabricator
Diffusion Bitcoin ABC 99ffce20b8d3

[ecash-herald] Add basic validation checks to make app robust against…
99ffce20b8d3
Actions

Description

[ecash-herald] Add basic validation checks to make app robust against unexpectedly formed OP_RETURN txs

Summary: It would be possible to crash ecash-herald by using known protocol identifiers to create OP_RETURN stacks of unexpected shape. Stop treating spec (including some unwritten spec) as natural law.

Test Plan: npm test

Reviewers: #bitcoin_abc, PiRK

Reviewed By: #bitcoin_abc, PiRK

Differential Revision: https://reviews.bitcoinabc.org/D14210

Details

Provenance
bytesofmanAuthored on Jul 4 2023, 21:23
bytesofmanPushed on Jul 5 2023, 13:11
Reviewer
Restricted Project
Differential Revision
D14210: [ecash-herald] Add basic validation checks to make app robust against unexpectedly formed OP_RETURN txs
Parents
rABC368442f322ed: use git filter-repo instead of git filter-branch for the secp256k1 repository
Branches
Unknown
Tags
Unknown

Changes (3)

PathSize
apps/
ecash-herald/
src/
test/
mocks/

rABC99ffce20b8d3

View Options

apps/ecash-herald/src/parse.js

Loading...
View Options

apps/ecash-herald/test/mocks/appTxSamples.js

Loading...
View Options

apps/ecash-herald/test/parseTests.js

Loading...