HomePhabricator

[backport#19489] test: Fail wait_until early if connection is lost

Description

[backport#19489] test: Fail wait_until early if connection is lost

Summary:
faa9a74c9e99eb43ba0d27fa906767ee88011aeb test: Fail wait_until early if connection is lost (MarcoFalke)

Pull request description:

Calling `minonode.wait_until` needs a connection to make progress (e.g. waiting for an inv), unless the mininode waits for the initial connection or for a disconnection. So for test development and failure debugging, fail early in all `wait_until`, unless opted out.

Depends on D9514

Backport of core#19489

Test Plan:

ninja all check check-functional

Reviewers: #bitcoin_abc, PiRK

Reviewed By: #bitcoin_abc, PiRK

Differential Revision: https://reviews.bitcoinabc.org/D9515

Details

Provenance
MarcoFalke <falke.marco@gmail.com>Authored on Aug 4 2020, 09:21
majcostaCommitted on May 13 2021, 12:34
majcostaPushed on May 13 2021, 12:34
Reviewer
Restricted Project
Differential Revision
D9515: [backport#19489] test: Fail wait_until early if connection is lost
Parents
rABC7300d7291145: [backport#19304] test: Check that message sends successfully when header is…
Branches
Unknown
Tags
Unknown