HomePhabricator

[Cashtab-components] Upgrade storybook by running npx sb upgrade

Description

[Cashtab-components] Upgrade storybook by running npx sb upgrade

Summary:
T2634

Upgrading storybook as a pre-req to successfully running npm upgrade, which otherwise fails due to peer deps

Interesting to note that upgrading storybook per their recommended procedure --- running npx sb upgrade --- simply adds a .npmrc file with legacy-peer-deps=true ... which is not really a 'solution' for this problem. Interesting JS practices even at a module with over 3 million downloads per week.

Test Plan:
npm run storybook and note display loads with no errors
npm run build and no errors

Reviewers: #bitcoin_abc, kieran709

Reviewed By: #bitcoin_abc, kieran709

Differential Revision: https://reviews.bitcoinabc.org/D11900

Details

Provenance
bytesofmanAuthored on Aug 31 2022, 21:04
bytesofmanPushed on Aug 31 2022, 21:46
Reviewer
Restricted Project
Differential Revision
D11900: [Cashtab-components] Upgrade storybook by running npx sb upgrade
Parents
rABC18c038f60b58: [Cashtab] Upgrading dependencies
Branches
Unknown
Tags
Unknown