HomePhabricator

Merge #11710: cli: Reject arguments to -getinfo

Description

Merge #11710: cli: Reject arguments to -getinfo

Summary:
dcfef27 cli: Reject arguments to -getinfo (Wladimir J. van der Laan)

Pull request description:

Currently it's possible to accidentally type e.g.

    bitcoin-cli -getinfo getbalance

and get an answer which can be confusing; the trailing arguments are just ignored.

To avoid this, throw an error if the user provides arguments to
`-getinfo`.

Tree-SHA512: 3603e8fa852b884d1dd3b7462db40b092fe8b3390fd4384b4ee330315d797aff711e9f62990012fd4b5a55c8678734ba8497a5488a09ee6b65cf8a99017d6eb4

Backport of Core PR11710
https://github.com/bitcoin/bitcoin/pull/11710/

Please note, this is ./bitcoin-cli -getinfo, NOT the deprecated/removed RPC call.

Test Plan:

make check
test_runner.py

Reviewers: jasonbcox, deadalnix, Fabien, O1 Bitcoin ABC, #bitcoin_abc, markblundeberg

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, markblundeberg

Subscribers: markblundeberg

Differential Revision: https://reviews.bitcoinabc.org/D3229

Details

Provenance
Wladimir J. van der Laan <laanwj@gmail.com>Authored on Nov 18 2017, 11:05
nakihitoCommitted on Jun 6 2019, 17:55
nakihitoPushed on Jun 6 2019, 17:55
Reviewer
Restricted Owners Package
Differential Revision
D3229: Merge #11710: cli: Reject arguments to -getinfo
Parents
rABC23a9331c222d: Fix a bunch of spelling errors
Branches
Unknown
Tags
Unknown

Event Timeline