HomePhabricator

Fix crash in importwallet and dumpwallet formatting
a143d4ce58d1Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Fix crash in importwallet and dumpwallet formatting

  • DecodeDumpTime was passing a statically allocated facet object to std::locale. However, "The constructed locale object takes over responsibility for deleting this facet object." causing a free() crash on scope exit. Fixes #3670.
  • EncodeDumpTime was using the wrong format character for dates (appears accidentally introduced in 51ed9ec9)

Details

Provenance
Wladimir J. van der Laan <laanwj@gmail.com>Authored on Feb 17 2014, 10:32
deadalnixPushed on May 14 2017, 22:04
Parents
rABC129429dd8f6d: Merge pull request #3643
Branches
Unknown
Tags
Unknown

Event Timeline

Wladimir J. van der Laan <laanwj@gmail.com> committed rABCa143d4ce58d1: Fix crash in importwallet and dumpwallet formatting (authored by Wladimir J. van der Laan <laanwj@gmail.com>).Feb 17 2014, 17:42