HomePhabricator

[lint] Fix remaining arguments shadowing python builtins

Description

[lint] Fix remaining arguments shadowing python builtins

Summary:
This eliminates the remaining arguments that shadow python builtins detected by flake8-builtins (error code A002).

The next step is to cleanup variables shadowing builtins (A001) and then enforce the linter plugin.

Test Plan:

pip3 install flake8-builtins
flake8 | grep A002  # should return nothing

Following instructions in /contrib/apple-sdk-tools/README.md:

./extract_xcode.py -f Xcode_*.xip | cpio -d -i

Also run MacOS build in CI.

Reviewers: #bitcoin_abc, PiRK

Reviewed By: #bitcoin_abc, PiRK

Differential Revision: https://reviews.bitcoinabc.org/D13739

Details

Provenance
sdulfariAuthored on Apr 11 2023, 16:34
sdulfariPushed on Apr 19 2023, 20:04
Reviewer
Restricted Project
Differential Revision
D13739: [lint] Fix remaining arguments shadowing python builtins
Parents
rABC89247877f79b: util: Avoid buggy std::filesystem:::create_directories() call
Branches
Unknown
Tags
Unknown