Page MenuHomePhabricator

[lint] Fix remaining arguments shadowing python builtins
ClosedPublic

Authored by sdulfari on Apr 19 2023, 17:36.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABCa1e08a5f4a70: [lint] Fix remaining arguments shadowing python builtins
Summary

This eliminates the remaining arguments that shadow python builtins detected by flake8-builtins (error code A002).

The next step is to cleanup variables shadowing builtins (A001) and then enforce the linter plugin.

Test Plan
pip3 install flake8-builtins
flake8 | grep A002  # should return nothing

Following instructions in /contrib/apple-sdk-tools/README.md:

./extract_xcode.py -f Xcode_*.xip | cpio -d -i

Also run MacOS build in CI.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable