This eliminates the remaining arguments that shadow python builtins detected by flake8-builtins (error code A002).
The next step is to cleanup variables shadowing builtins (A001) and then enforce the linter plugin.
Details
Details
- Reviewers
PiRK - Group Reviewers
Restricted Project - Commits
- rABCa1e08a5f4a70: [lint] Fix remaining arguments shadowing python builtins
pip3 install flake8-builtins flake8 | grep A002 # should return nothing
Following instructions in /contrib/apple-sdk-tools/README.md:
./extract_xcode.py -f Xcode_*.xip | cpio -d -i
Also run MacOS build in CI.
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- flake8-builtins-a002
- Lint
Lint Errors Severity Location Code Message Error contrib/tracing/p2p_monitor.py:89 A003 flake8 A003 - Unit
No Test Coverage - Build Status
Buildable 23369 Build 46357: Build Diff Build 46356: arc lint + arc unit
Event Timeline
Comment Actions
Ignore the lint error. This comes from my local machine which has flake8-builtins installed.