HomePhabricator

[test] Manage node connections better in mempool persist test

Description

[test] Manage node connections better in mempool persist test

Summary:
there were two calls to disconnect_nodes that were no-ops. fixed one & removed
the other & added assertions to confirm node has no connections when creating
the unbroadcast transaction.

This is a backport of Core PR18807
https://github.com/bitcoin/bitcoin/pull/18807/commits/fa32e676e5833a5c5fc735ef00c0a80f5fab7a2c

Test Plan: test/functional/test_runner.py mempool_persist

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D9033

Details

Provenance
Amiti Uttarwar <amiti@uttarwar.org>Authored on Jan 22 2021, 11:14
PiRKCommitted on Jan 22 2021, 11:14
abc-botPushed on Jan 22 2021, 11:17
Reviewer
Restricted Project
Differential Revision
D9033: [test] Manage node connections better in mempool persist test
Parents
rABC63c9d13451b6: [net_processing] Pass chainparams to PeerLogicValidation constructor
Branches
Unknown
Tags
Unknown