HomePhabricator

[backport#16659] refactoring: Remove unused includes

Description

[backport#16659] refactoring: Remove unused includes

Summary:
084e17cebd424b8e8ced674bc810eef4e6ee5d3b Remove unused includes (practicalswift)

Pull request description:

As requested by MarcoFalke in https://github.com/bitcoin/bitcoin/pull/16273#issuecomment-521332089:

This PR removes unused includes.

Please note that in contrast to #16273 I'm limiting the scope to the trivial cases of pure removals (i.e. no includes added) to make reviewing easier.

I'm seeking "Concept ACK":s for this obviously non-urgent minor cleanup.

Rationale:
* Avoids unnecessary re-compiles in case of header changes.
* Makes reasoning about code dependencies easier.
* Reduces compile-time memory usage.
* Reduces compilation time.
* Warm fuzzy feeling of being lean :-)

ACKs for top commit:

ryanofsky:
  Code review ACK 084e17cebd424b8e8ced674bc810eef4e6ee5d3b. PR only removes include lines and it still compiles. In the worst case someone might have to explicitly add an include later for something now included implicitly. But maybe some effort was taken to avoid this, and it wouldn't be a tragedy anyway.

Backport of Core PR16659

Test Plan:

ninja check-all
ninja

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Subscribers: deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D6586

Details

Provenance
MarcoFalke <falke.marco@gmail.com>Authored on Oct 16 2019, 21:33
majcostaCommitted on Jun 15 2020, 20:56
majcostaPushed on Jun 15 2020, 20:56
Reviewer
Restricted Project
Differential Revision
D6586: [backport#16659] refactoring: Remove unused includes
Parents
rABC2002093682f1: Use the new Check facility in rpc/rawtransaction.cpp
Branches
Unknown
Tags
Unknown